Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Adding tests for dynamicUrlToDependency #58

Closed
wants to merge 2 commits into from

Conversation

gauntface
Copy link

No description provided.

@gauntface
Copy link
Author

Looks like I'm doing something wrong but I'm a little lost at what the travis-ci/pr test is doing.

The mocha test run fine before the error line.

I'm trying to find out how to reproduce the problems locally, but I can't replicate it, instead I get a tonne of errors from eslint (Around 82 Errors, largely deprecation notices).

@jeffposnick
Copy link
Contributor

The additional tests are great!

I just did a clean checkout of master, ran npm install, and then was able to successfully run both gulp test and gulp lint without any issues. I'm not sure why you ended up needing to include various linting changes in this PR, but they don't appear necessary to me. Can you try again with a clean checkout/npm install and see if you run into whatever problems you faced initially related to linting?

If you do see issues with our linting setup, let's address it in a separate PR, ideally one that also involves moving to the new Google-specific eslint config. See #66

I think it would be ideal to just limit this PR to the new tests.

@gauntface gauntface closed this Dec 4, 2015
@gauntface
Copy link
Author

Will address in seperate PR's.

The linting caused issues in travis and when I ran it locally the linting through up way to many warnings for my liking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants